fix(plan): avoid impossible top-level field suggestions#3
Merged
Conversation
Constrain `ergo plan` unknown-field suggestions to top-level schema keys only.\nThis prevents suggesting `after` for unknown top-level keys, which is misleading because `after` is task-scoped only.\nRename the candidate list to clarify intent and preserve existing parser behavior.\nAdd a focused regression test for top-level typo input (`aftr`) to ensure no nested-only suggestion leaks through.\nKeep existing behavior for valid top-level suggestions (like `boddy` -> `body`).\nNo CLI contract changes beyond clearer parse_error messaging for this edge case.\nThis keeps feedback aligned with quickstart/spec input shape and reduces correction loops for agents.\nRisk is low: change is scoped to suggestion candidate selection for plan parsing only.\nTests: go test ./...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ergo plantypo suggestions to valid top-level keys only (title,body,tasks)afterfor unknown top-level fieldsaftr)Why
Top-level typos were receiving a misleading suggestion (
after) that is only valid insidetasks[], which can send agents and humans down the wrong correction path.Validation
go test ./...task ci):go mod tidy,golangci-lint,go test -race ./...